Security: Server-side XSS sink in Streamlit app (unsafe_allow_html=True) with model-controlled content#92
Open
tuanaiseo wants to merge 1 commit intodatalab-to:masterfrom
Conversation
The Streamlit UI renders OCR/model output using `st.markdown(..., unsafe_allow_html=True)`. Model output is not sanitized and may contain arbitrary HTML/JS-like payloads if prompted or induced by crafted input documents. This can execute script in users' browsers when viewing OCR results. Affected files: app.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Streamlit UI renders OCR/model output using
st.markdown(..., unsafe_allow_html=True). Model output is not sanitized and may contain arbitrary HTML/JS-like payloads if prompted or induced by crafted input documents. This can execute script in users' browsers when viewing OCR results.Severity:
highFile:
chandra/scripts/app.pySolution
Avoid
unsafe_allow_html=Truefor untrusted content. If HTML rendering is required, sanitize output first using a strict allowlist sanitizer (e.g., Bleach) that removes scripts, event handlers, dangerous URLs (javascript:), and unsafe attributes/styles.Changes
chandra/scripts/app.py(modified)Testing